Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration grade icon rebase onto origin 8.0.x #898

Open
wants to merge 3 commits into
base: 9.x
Choose a base branch
from

Conversation

Shounaks
Copy link

Description

The purpose of grade-icon is to provide a unified simple component, for displaying the grade student is expecting.
Refer Documentation PR for Initial Information: thoth-tech/documentation#561
Refer Previous Declined PR (for dev branch.).

This PR has been rebased to match with 8.0.x: thoth-tech#258
This PR is also based on my previous PR to Thoth-Tech: thoth-tech#259

Fixes # (issue)

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I have tested this code is working in browser and will be appending screenshots for the following to the Documentation PR.

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [] I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from @macite and @jakerenzella on the Pull Request

Screenshots Before Change:

students-list

image

portfolios:

image
image

group-member-contribution-assigner:

image

Student Group

image

Screenshots After Change:

students-list

image

portfolios:

image
image

group-member-contribution-assigner:

image

Student Group

image

Other Images

image

@macite macite changed the base branch from 8.0.x to 9.x November 25, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant